Adding functions and types to calculate AUTH and ID blocks #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGonzalezVillal
requested review from
tylerfanelli and
larrydewey
as code owners
DGonzalezVillal
force-pushed
the
id-block
branch
from
ee7123c to
ba5035f
Compare
larrydewey
requested changes
Jan 22, 2024
DGonzalezVillal
force-pushed
the
id-block
branch
3 times, most recently
from
9584cc6 to
b3e9000
Compare
larrydewey
reviewed
Feb 15, 2024
|
Also added the Guest Features for the VMSA to this PR. This can affect the measurement depending on which kernel features are enabled. |
DGonzalezVillal
force-pushed
the
id-block
branch
from
ca6c3f7 to
5ac991d
Compare
larrydewey
requested changes
Feb 16, 2024
DGonzalezVillal
force-pushed
the
id-block
branch
from
5ac991d to
823fec8
Compare
|
@tylerfanelli whenever you can, can you please review |
Signed-off-by: DGonzalezVillal <Diego.GonzalezVillalobos@amd.com>
Signed-off-by: DGonzalezVillal <Diego.GonzalezVillalobos@amd.com>
Signed-off-by: DGonzalezVillal <Diego.GonzalezVillalobos@amd.com>
DGonzalezVillal
force-pushed
the
id-block
branch
from
823fec8 to
9d2e130
Compare
tylerfanelli
approved these changes
Feb 21, 2024
Comment on lines
+817
to
+839
| #[cfg(all(feature = "snp", feature = "openssl"))] | ||
| impl std::convert::From<openssl::error::ErrorStack> for IdBlockError { | ||
| fn from(value: openssl::error::ErrorStack) -> Self { | ||
| Self::CryptoErrorStack(value) | ||
| } | ||
| } | ||
|
|
||
| impl std::convert::From<LargeArrayError> for IdBlockError { | ||
| fn from(value: LargeArrayError) -> Self { | ||
| Self::LargeArrayError(value) | ||
| } | ||
| } | ||
|
|
||
| impl std::convert::From<std::io::Error> for IdBlockError { | ||
| fn from(value: std::io::Error) -> Self { | ||
| Self::FileError(value) | ||
| } | ||
| } | ||
| impl std::convert::From<bincode::ErrorKind> for IdBlockError { | ||
| fn from(value: bincode::ErrorKind) -> Self { | ||
| Self::BincodeError(value) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can't these be converted by map_err()? Is the From implementation necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functions and types that will allow users to calculate authority and id blocks