Bugfix: disinclude Degree and Deviation from plottable attributes

visdesignlab · Jan 8, 2025 · c93cf45 · c93cf45
1 parent 064918b
commit c93cf45
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/packages/upset/src/atoms/attributeAtom.ts b/packages/upset/src/atoms/attributeAtom.ts
@@ -1,4 +1,4 @@
-import { atom, selectorFamily } from 'recoil';
+import { atom, selector, selectorFamily } from 'recoil';
 
 import { itemsAtom } from './itemsAtoms';
 
@@ -10,6 +10,17 @@ export const attributeAtom = atom<string[]>({
   default: [],
 });
 
+/**
+ * All attribute columns except Degree and Deviation
+ */
+export const dataAttributeSelector = selector<string[]>({
+  key: 'data-attribute-columns',
+  get: ({ get }) => {
+    const atts = get(attributeAtom);
+    return atts.filter((att) => att !== 'Degree' && att !== 'Deviation');
+  },
+});
+
 /**
  * Gets all non-NaN values for a given attribute
  * @param {string} attribute Attribute name

diff --git a/packages/upset/src/components/ElementView/AddPlot.tsx b/packages/upset/src/components/ElementView/AddPlot.tsx
@@ -14,7 +14,7 @@ import {
 import { FC, useContext, useState } from 'react';
 import { useRecoilValue } from 'recoil';
 
-import { attributeAtom } from '../../atoms/attributeAtom';
+import { attributeAtom, dataAttributeSelector } from '../../atoms/attributeAtom';
 import { itemsAtom } from '../../atoms/itemsAtoms';
 import { ProvenanceContext } from '../Root';
 import { HistogramPlot } from './HistogramPlot';
@@ -140,7 +140,7 @@ export const AddScatterplot: FC<Props> = ({ handleClose }) => {
 export const AddHistogram: FC<Props> = ({ handleClose }) => {
   const { actions } = useContext(ProvenanceContext);
   const items = useRecoilValue(itemsAtom);
-  const attributeColumns = useRecoilValue(attributeAtom);
+  const attributeColumns = useRecoilValue(dataAttributeSelector);
   const [attribute, setAttribute] = useState(attributeColumns[0]);
   const [bins, setBins] = useState(20);
   // Frequency plots are temporarily disabled, see comment further down