Merge pull request #319 from visdesignlab/isu306-trrack-filter-dups

Bugfix: no Trrack action for unchanged filters
visdesignlab · Mar 25, 2024 · cb64fb6 · cb64fb6
2 parents 3f44d6c + 725d44d
commit cb64fb6
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/upset/src/components/Sidebar.tsx b/packages/upset/src/components/Sidebar.tsx
@@ -71,6 +71,8 @@ export const Sidebar = () => {
   );
 
   const [degreeFilters, setDegreeFilters] = useState([minVisible, maxVisible]);
+  // Tracking the previous state of the filters to avoid unnecessary updates
+  const [prevFilters, setPrevFilters] = useState([minVisible, maxVisible]);
 
   useEffect(() => {
     if (firstAggregateBy === 'None') {
@@ -286,8 +288,14 @@ export const Sidebar = () => {
                   }
                 }}
                 onChangeCommitted={() => {
-                  actions.setMinVisible(degreeFilters[0]);
-                  actions.setMaxVisible(degreeFilters[1]);
+                  // Prevents unncessary Trrack state changes
+                  if (prevFilters[0] !== degreeFilters[0]) {
+                    actions.setMinVisible(degreeFilters[0]);
+                  }
+                  if (prevFilters[1] !== degreeFilters[1]) {
+                    actions.setMaxVisible(degreeFilters[1]);
+                  }
+                  setPrevFilters(degreeFilters);
                 }}
               />
             </Box>