Skip to content

Commit

Permalink
Clarify plot information fields & make placeholders more accessible w…
Browse files Browse the repository at this point in the history
…ith labels
  • Loading branch information
Nate Lanza committed Jul 18, 2024
1 parent ef2d454 commit d582d26
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions packages/upset/src/components/custom/PlotInformation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ export const PlotInformation = ({onSave, divider, tabIndex}: Props) => {
};

const placeholderText = {
description: 'movie genres and ratings',
sets: 'movie genres (dataset columns)',
items: 'movies (dataset rows)',
description: 'description of this dataset, eg: "movie genres and ratings"',
sets: 'name for the sets in this dataset, eg: "movie genres"',
items: 'name for the items in this dataset, eg: "movies"',
};

const plotInformationState = useRecoilValue(plotInformationSelector);
Expand Down Expand Up @@ -196,7 +196,8 @@ export const PlotInformation = ({onSave, divider, tabIndex}: Props) => {
value={plotInformation.description}
fullWidth
maxRows={8}
placeholder={`eg: ${placeholderText.description}`}
placeholder={`${placeholderText.description}`}
aria-label={`${placeholderText.description}`}
/>
</Box>
</Box>
Expand All @@ -214,7 +215,8 @@ export const PlotInformation = ({onSave, divider, tabIndex}: Props) => {
value={plotInformation.sets}
fullWidth
maxRows={8}
placeholder={`eg: ${placeholderText.sets}`}
placeholder={`${placeholderText.sets}`}
aria-label={`${placeholderText.sets}`}
/>
</Box>
</Box>
Expand All @@ -232,7 +234,8 @@ export const PlotInformation = ({onSave, divider, tabIndex}: Props) => {
value={plotInformation.items}
fullWidth
maxRows={8}
placeholder={`eg: ${placeholderText.items}`}
placeholder={`${placeholderText.items}`}
aria-label={`${placeholderText.items}`}
/>
</Box>
</Box>
Expand Down

0 comments on commit d582d26

Please sign in to comment.