Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing for "report a bug" button #320

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix spacing for "report a bug" button #320

merged 2 commits into from
Mar 25, 2024

Conversation

NateLanza
Copy link
Contributor

Does this PR close any open issues?

Closes #278

Give a longer description of what this PR addresses and why it's needed

Previously, the "Report a Bug" button in the footer had different spacing than the elements around it (icon/text appeared slightly above center). By applying the styling to the outermost component (instead of the inner as previous) the issue appears fixed.

Provide pictures/videos of the behavior before and after these changes (optional)

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • ...

@NateLanza NateLanza requested a review from JakeWags March 23, 2024 23:22
@NateLanza NateLanza self-assigned this Mar 23, 2024
Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit a59a126
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/6601a31ea8e8f60008d4715a
😎 Deploy Preview https://deploy-preview-320--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Simple change thanks for doing that.

@NateLanza NateLanza merged commit cdf6839 into main Mar 25, 2024
7 checks passed
@NateLanza NateLanza deleted the isu278-foot-size branch March 25, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different sizing of buttons in the footer-ooter
2 participants