Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trrack selecting and deselecting intersections #333

Merged
merged 21 commits into from
Apr 5, 2024
Merged

Conversation

NateLanza
Copy link
Contributor

Does this PR close any open issues?

Closes #257
Closes #332

Give a longer description of what this PR addresses and why it's needed

Selecting an intersection changes the plot in a meaningful way that should be trracked; this adds a Trrack action for selections and deselections and includes the currently selected row in the plot state (including the JSON export).

Provide pictures/videos of the behavior before and after these changes (optional)

Before:
Screenshot 2024-03-30 at 8 47 30 PM
After:
Screenshot 2024-03-30 at 8 48 05 PM

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • Is adding the 'selected' field to the state export going to break any connected apps? The alttxt generation still works fine and passes its test.

@NateLanza NateLanza requested review from JakeWags and JackWilb March 31, 2024 02:52
@NateLanza NateLanza self-assigned this Mar 31, 2024
Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit d784e7a
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/660c9d179dc61a00086f99c2
😎 Deploy Preview https://deploy-preview-333--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, excellent work! A few questions about replacing the verbose if statements (x.y === null) with x?.y === blah and the conditions when those could fail (if they will).

Major change requested is to clean the trrack-vis e2e test so that it is readable and modifiable.

@NateLanza NateLanza requested a review from JakeWags April 1, 2024 22:24
Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't see any issues with the merge.

@NateLanza NateLanza merged commit 9830e41 into main Apr 5, 2024
7 checks passed
@NateLanza NateLanza deleted the trrack-selection branch April 5, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants