-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trrack selecting and deselecting intersections #333
Conversation
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, excellent work! A few questions about replacing the verbose if statements (x.y === null
) with x?.y === blah
and the conditions when those could fail (if they will).
Major change requested is to clean the trrack-vis e2e test so that it is readable and modifiable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't see any issues with the merge.
Does this PR close any open issues?
Closes #257
Closes #332
Give a longer description of what this PR addresses and why it's needed
Selecting an intersection changes the plot in a meaningful way that should be trracked; this adds a Trrack action for selections and deselections and includes the currently selected row in the plot state (including the JSON export).
Provide pictures/videos of the behavior before and after these changes (optional)
Before:


After:
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
TODOs: