Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute plot safari position fix #467

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Attribute plot safari position fix #467

merged 2 commits into from
Feb 3, 2025

Conversation

JakeWags
Copy link
Member

@JakeWags JakeWags commented Feb 3, 2025

Does this PR close any open issues?

Closes #396

Give a longer description of what this PR addresses and why it's needed

This pull request addresses a layout issue in Safari for the MemoizedDensityVega component by modifying the VegaLite element's styling (position attribute). The change ensures compatibility across different browsers without affecting the layout in non-Safari browsers.

In truth, I am not sure why Safari is having issues with position: relative, as I initially expected it was an issue with us not using -webkit-transform or some similar webkit specific property.

Changes to improve browser compatibility:

Provide pictures/videos of the behavior before and after these changes (optional)

BEFORE: (SAFARI)
image

AFTER: (SAFARI)

image

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • None

@JakeWags JakeWags added the bug Something isn't working label Feb 3, 2025
@JakeWags JakeWags self-assigned this Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit baf1507
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/67a0fcd91078a5000833a5d4
😎 Deploy Preview https://deploy-preview-467--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakeWags JakeWags requested a review from JackWilb February 3, 2025 17:44
@JakeWags JakeWags merged commit b204a82 into main Feb 3, 2025
7 checks passed
@JakeWags JakeWags deleted the 396-safari-vega-fixes branch February 3, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Violin plots render incorrectly on safari
2 participants