Attribute plot safari position fix #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #396
Give a longer description of what this PR addresses and why it's needed
This pull request addresses a layout issue in Safari for the
MemoizedDensityVega
component by modifying theVegaLite
element's styling (position attribute). The change ensures compatibility across different browsers without affecting the layout in non-Safari browsers.In truth, I am not sure why Safari is having issues with
position: relative
, as I initially expected it was an issue with us not using-webkit-transform
or some similar webkit specific property.Changes to improve browser compatibility:
/components/Columns/Attribute/AttributePlots/MemoizedDensityVega.tsx
: Added a CSS property to theVegaLite
element to prevent layout issues in Safari, usingcss={{ position: 'initial !important' }}
to override the position property set byreact-vega
.Provide pictures/videos of the behavior before and after these changes (optional)
BEFORE: (SAFARI)

AFTER: (SAFARI)
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
TODOs: