forked from life4/deal
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from life4:master #7
Open
pull
wants to merge
83
commits into
vishalbelsare:master
Choose a base branch
from
life4:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions
Python 3.11 compatibility
Update pytest and mypy
Migrate project metadata to PEP 621
Update sphinx
doc minor fixes
Failing test: ``` def test_unknown_command(capsys): result = main(argv=['unknown', 'a1', 'a2'], commands=dict(fake=FakeCommand)) assert result == 2 captured = capsys.readouterr() exp = "invalid choice: 'unknown' (choose from 'fake')" > assert exp in captured.err E assert "invalid choice: 'unknown' (choose from 'fake')" in "usage: python3 -m deal [-h] {fake} ...\npython3 -m deal: error: argument {fake}: invalid choice: 'unknown' (choose from fake)\n" E + where "usage: python3 -m deal [-h] {fake} ...\npython3 -m deal: error: argument {fake}: invalid choice: 'unknown' (choose from fake)\n" = CaptureResult(out='', err="usage: python3 -m deal [-h] {fake} ...\npython3 -m deal: error: argument {fake}: invalid choice: 'unknown' (choose from fake)\n").err tests/test_cli/test_main.py:27: AssertionError ```
Fix new mypy errors
Python 3.12.9 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )