Revert combine process order #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compensation benchmark file has to be processed after skills as otherwise the output gets corrupt. This fix doesn't deal with the root cause of that issue (corruption shouldn't happen for any file order), but we need to be able to generate correct documentation so the revert is the quickest fix.
Shmalikov
approved these changes
Feb 28, 2025
hareskoug
added a commit
that referenced
this pull request
Feb 28, 2025
* Update compensation-benchmarks.yaml Update to latest Signed-off-by: Emily Boegman-Watt <141189938+emily-watt-visier@users.noreply.github.com> * Update compensation-benchmarks.yaml Henrik's feedback Signed-off-by: Emily Boegman-Watt <141189938+emily-watt-visier@users.noreply.github.com> * Update compensation-benchmarks.yaml Signed-off-by: Emily Boegman-Watt <141189938+emily-watt-visier@users.noreply.github.com> * Revert combine process order (#170) The compensation benchmark file has to be processed after skills as otherwise the output gets corrupt. This fix doesn't deal with the root cause of that issue (corruption shouldn't happen for any file order), but we need to be able to generate correct documentation so the revert is the quickest fix. * Auto-merge: Update openapi Co-authored-by: Visier-Build-Team <svc-gitp-build@visier.com> * Update compensation-benchmarks.yaml Update to latest Signed-off-by: Emily Boegman-Watt <141189938+emily-watt-visier@users.noreply.github.com> * Update compensation-benchmarks.yaml Henrik's feedback Signed-off-by: Emily Boegman-Watt <141189938+emily-watt-visier@users.noreply.github.com> * Update compensation-benchmarks.yaml Signed-off-by: Emily Boegman-Watt <141189938+emily-watt-visier@users.noreply.github.com> --------- Signed-off-by: Emily Boegman-Watt <141189938+emily-watt-visier@users.noreply.github.com> Co-authored-by: Henrik Areskoug <67931019+hareskoug@users.noreply.github.com> Co-authored-by: visiersdkgenerator[bot] <176706189+visiersdkgenerator[bot]@users.noreply.github.com> Co-authored-by: Visier-Build-Team <svc-gitp-build@visier.com> Co-authored-by: Henrik Areskoug <henrik.areskoug@visier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compensation benchmark file has to be processed after skills as otherwise the output gets corrupt. This fix doesn't deal with the root cause of that issue (corruption shouldn't happen for any file order), but we need to be able to generate correct documentation so the revert is the quickest fix.
Also, bumped the OAS3 version from 3.0.0 to 3.0.3, which is the version we generate. The combined result had the wrong version in it