feat: Add Pagination Support #47
vkhitrinAnnotations
5 warnings
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/main.rs#L264
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/app.rs:264:17
|
264 | &self.placeholder_account.as_ref().unwrap(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.placeholder_account.as_ref().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `i64` which implements the `Copy` trait:
src/main.rs#L293
warning: using `clone` on type `i64` which implements the `Copy` trait
--> src/app.rs:293:55
|
293 | Message::CompleteRemoveDialog(account.clone(), Some(bookmark.clone())),
| ^^^^^^^^^^^^^^^ help: try dereferencing it: `*account`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
accessing first element with `result.get(0)`:
src/main.rs#L405
warning: accessing first element with `result.get(0)`
--> src/db/mod.rs:405:32
|
405 | let row_count: usize = result
| ________________________________^
406 | | .get(0)
| |___________________^ help: try: `result.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
|
length comparison to zero:
src/main.rs#L90
warning: length comparison to zero
--> src/models/db_cursor.rs:90:20
|
90 | if bookmarks.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!bookmarks.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
|
length comparison to zero:
src/main.rs#L396
warning: length comparison to zero
--> src/pages/bookmarks.rs:396:20
|
396 | if self.query_placeholder.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.query_placeholder.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|