Add antrea-interworking package #5578
Conversation
|
Hi @wenqiq! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Community Edition better. |
| config: | ||
| #@schema/desc "echo -n 'dummyAdmin' | base64" | ||
| nsxUser: ZHVtbXlBZG1pbg== | ||
| #@schema/desc " echo -n 'dummyPassword' | base64" |
There was a problem hiding this comment.
No unified style for filed name? . like nsxUser. ClusterName --> clusterName?
| #@schema/desc " " | ||
| ClusterName: dummyClusterName | ||
| #@schema/desc " " | ||
| NSXIP1: dummyNSXIP1 |
There was a problem hiding this comment.
Does these default value make sense if applied?
| - anyMatcher: | ||
| matchers: | ||
| - kindNamespaceNameMatcher: {kind: APIService, namespace: kube-system, name: v1alpha1.stats.antrea.io} | ||
| - kindNamespaceNameMatcher: {kind: APIService, namespace: kube-system, name: v1alpha1.stats.antrea.tanzu.vmware.com} |
There was a problem hiding this comment.
I have checked and there is no APIService in interworking.
Do you have any comments about this?@edwardbadboy
There was a problem hiding this comment.
Correct. No APIService in interworking.
|
Also, yaml and lint tests should pass |
wenqiq
force-pushed
the
wenqi/antrea-interworking
branch
from
ddd440a to
1f664f6
Compare
wenqiq
force-pushed
the
wenqi/antrea-interworking
branch
from
e271bd3 to
07d3be1
Compare
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
wenqiq
force-pushed
the
wenqi/antrea-interworking
branch
from
07d3be1 to
e07c351
Compare
wenqiq
force-pushed
the
wenqi/antrea-interworking
branch
from
e07c351 to
6154da0
Compare
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
wenqiq
force-pushed
the
wenqi/antrea-interworking
branch
from
6154da0 to
4044822
Compare
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
wenqiq
force-pushed
the
wenqi/antrea-interworking
branch
from
f122634 to
9d3b8fd
Compare
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
…ootstrapFrom Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu wenqiq@vmware.com
What this PR does / why we need it
Add Antrea-interworking Package
Which issue(s) this PR fixes
Fixes: #
Describe testing done for PR
Special notes for your reviewer