Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vmFolder option to deploy_ova module #526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tim-krehan
Copy link

Description

This merge request introduces a new option, vmFolder, to the deploy_ova module. The addition allows users to specify a folder within the ESX cluster where the desired VM should be created.
The already used folder parameter is leveraged. When the user specifies it, the OVFTool parameter --vmFolder is added to the ovf_base_options array.

Changes Made

  • Added a check for the folder parameter in the deploy_ova module.
  • Extended the ovf_command with the --vmFolder option if the folder parameter is provided.
  • Removed the previous logic that appended the folder to the vi_string. This seemed to be a bug. It didn't work if the parameter was specified.

Testing

  • Verified that the deploy_ova module correctly includes the --vmFolder option when the folder parameter is specified.
  • Ensured that the module functions as expected without the folder parameter.

Thank you for considering this merge request. Please let me know if there are any questions or further improvements needed.

@vmwclabot
Copy link
Member

@tim-krehan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Tim Krehan <github@timkrehan.de>
@tim-krehan tim-krehan force-pushed the fix-inventory-folder-for-nsx-deploy-ova-module branch from 85f8bdf to a5eafd4 Compare January 2, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants