Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store images on the repo #10

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Store images on the repo #10

merged 3 commits into from
Nov 29, 2023

Conversation

martinRenou
Copy link
Member

No description provided.

trungleduc
trungleduc reviewed Nov 29, 2023
View reviewed changes
README.md Outdated
- `image_url`: the URL of the picture to use as thumbnail.
- `image_path`: the name of your picture under `public/images`.
Copy link
Member

@trungleduc trungleduc Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should support both, users can freely upload their images elsewhere. If they have the file in their repo, it's easy to get a direct link to this image too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍🏽

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should restore the deleted line? And maybe precise the public/images of the current repo, not the repo of the dashboard.

@trungleduc
Copy link
Member

Thanks!

@trungleduc trungleduc marked this pull request as ready for review November 29, 2023 17:06
@trungleduc trungleduc merged commit 031c1db into voila-dashboards:main Nov 29, 2023
2 checks passed
@jtpio
Copy link
Member

jtpio commented Nov 29, 2023

Would you mind providing context for storing images on the repo?

@jtpio
Copy link
Member

jtpio commented Nov 29, 2023

Would you mind providing context for storing images on the repo?

So that if we look at that again in a couple of months / years we understand why.

@martinRenou martinRenou deleted the pull_images branch November 29, 2023 17:58
@martinRenou
Copy link
Member Author

Would you mind providing context for storing images on the repo?

It seems the trick to store images on Github issues is not easily usable anymore and Github is switching to another system. So storing the images ourselves on the server may be easier.

Though in this PR we'll continue supporting externally hosted images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @trungleduc @jtpio