Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(backport 0.1.18) fix: throttle the rate AND number of request_state msg'es from the frontend #536

Merged
merged 11 commits into from
Feb 6, 2020
Merged

(backport 0.1.18) fix: throttle the rate AND number of request_state msg'es from the frontend #536

merged 11 commits into from
Feb 6, 2020

Conversation

maartenbreddels
Copy link
Member

Fixes #534, backport of #535

@maartenbreddels maartenbreddels force-pushed the 0.1.18.x_fix_throttle branch 2 times, most recently from 0ac7d3a to e5a1a2f Compare February 5, 2020 19:20
SylvainCorlay and others added 7 commits February 5, 2020 20:28
@SylvainCorlay @maartenbreddels
Only require nbconvert 5.5
cef933d
@aschlaep @maartenbreddels
Add cell error instruction configurable (voila-dashboards#471)
f82788a 
* add cell error instruction configurable in VoilaExecutePreprocessor
@maartenbreddels
fix: throttle the rate AND number of request_state msg'es from the fr…
c39c0a3 
…ontend

Fixes voila-dashboards#534

Related: jupyter-widgets/ipywidgets#2765
@maartenbreddels
test: expose nbconvert issue, when there are too many iopub messages
9a4eda0 
Since nbconvert wait for 1 second at the shell channel, the iopub messages
pile up, triggering the high water mark of 0mq, causing iopub messages
to be lost. This results in no output of the cell.
@maartenbreddels
fix: poll for shell and iopub socket at the same time to avoid hittin…
291a135 
…g high water mark
@maartenbreddels
make nbconvert 5.5 compatible
e18eba1
@maartenbreddels
update package-lock.json
ec5ee0d
@maartenbreddels maartenbreddels mentioned this pull request Feb 5, 2020
Closed
@maartenbreddels
Copy link
Member Author

The failure in test_execute_output I think is unrelated, I've seen it before:

E               AssertionError: assert {'output_type...text': u'hi4'} == {u'output_type...xt': u'hi4\n'}
E                 Omitting 2 identical items, use -vv to show
E                 Differing items:
E                 {'text': 'hi4'} != {'text': 'hi4\n'}
E

@maartenbreddels maartenbreddels merged commit 33c1999 into voila-dashboards:0.1.18.x Feb 6, 2020
@SylvainCorlay SylvainCorlay mentioned this pull request Feb 28, 2020
Merged
@SylvainCorlay SylvainCorlay mentioned this pull request May 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maartenbreddels @SylvainCorlay @aschlaep