Update to zip 0.5 to resolve bzip2 issue #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only gets us part of the way to fully updated, but our MSRV and the transitive MSRV of one of zip's dependencies means we cannot yet upgrade all the way to v0.6 (latest). It is sufficient to get the vulnerability eliminated, though! Fixes #1599
|
Note: this is failing two smoke tests locally:
It's unclear why that would be, and it's possible it's not a real issue. Will dig in further at some point later (or just be happy if CI is ✅!). |
|
Hooray, they pass! I do need to dig into why they failed locally, though, so that we don't end up in flakey test hell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only gets us part of the way to fully updated, but our MSRV and the transitive MSRV of one of zip's dependencies means we cannot yet upgrade all the way to v0.6 (latest). It is sufficient to get the vulnerability eliminated, though!
Fixes #1599