Fix Archlinux acceptance test

[TheMeier]

This fixes the Archlinux tests. Most notably the default for install_method is reset to the default for Archlinux. This is because most exporters actually don't have a package for Archlinux. The changes are somwhat backwards incompatible, but I would argue that previously the module was broken for Archlinux. So I consider this a bugfix instead.

[binford2k]

Hallo! Fill out this form if you'd like to claim your May the Source Be With You sticker! https://forms.office.com/r/Cn55uJmWMH

[hashworks]

EDIT: Nevermind, I had an error on my side.

[hashworks]

One thing doesn't seem to work though: Arch Prometheus expects the WorkingDirectory to be /usr/share/prometheus, otherwise it can't load the frontend assets.

Error opening React index.html: open static/react/index.html: no such file or directory

https://gitlab.archlinux.org/archlinux/packaging/packages/prometheus/-/blob/main/prometheus.service?ref_type=heads#L12

[TheMeier]

IIRC this PR did not touch anything related here. Can you try to set it yourself using prometheus::systemd_service_options

[hashworks]

This PR sets prometheus::server::manage_init_file to true on Arch, which overrides the service file provided by the package manager. The service file of this module does not set WorkingDirectory.

Of course, I can fix this by setting systemd_service_options, but this shouldn't be the expected solution.

[TheMeier]

I see. Part of the issue is that this is the only target where prometheus::server::install_method is set to package. That is also the reason why the tests have been broken for such a long time.

Ideally install_method would be set to package for all components and exporters for all targets that provide packages, but that would be a massive undertaking. This is also one of the reasons why I advocate for splitting up this module.

I will have a look at it and see if I can provide a fix. Or if you would like to have a go at it pull requests are always welcome.

In the meantime could you please file a new issue for this?

[TheMeier]

I have made quick test in a vagrant box. adding WorkingDirectory=/usr/share/prometheus fixes at least the error you reported @hashworks. I will check if we could just revert prometheus::server::install_method for archlinux or if we need to do something else.

This is the full diff between the package unit file and the module generated one:

--- /usr/lib/systemd/system/prometheus.service	2024-07-10 13:36:16.000000000 +0000
+++ prometheus.service	2024-07-14 17:56:55.905550700 +0000
@@ -1,19 +1,19 @@
+# Deployed with puppet
+#
+
 [Unit]
-Description=Prometheus service
-Documentation=https://prometheus.io/docs/prometheus
-Requires=network-online.target
-After=network-online.target nss-lookup.target
-Wants=network-online.target nss-lookup.target
+Description=Prometheus Monitoring framework
+Wants=basic.target
+After=basic.target
+After=network.target
 
 [Service]
 User=prometheus
 Group=prometheus
-Restart=on-failure
-WorkingDirectory=/usr/share/prometheus
-EnvironmentFile=-/etc/conf.d/prometheus
-ExecStart=/usr/bin/prometheus --config.file=/etc/prometheus/prometheus.yml --storage.tsdb.path=/var/lib/prometheus/data $PROMETHEUS_ARGS
+ExecStart=/usr/bin/prometheus --config.file=/etc/prometheus/prometheus.yml --web.console.templates=/usr/local/share/prometheus/consoles --web.console.libraries=/usr/local/share/prometheus/console_libraries --storage.tsdb.path=/var/lib/prometheus --storage.tsdb.retention.time=360h
 ExecReload=/bin/kill -HUP $MAINPID
-LimitNOFILE=65535
+KillMode=process
+Restart=always
 NoNewPrivileges=true
 ProtectHome=true
 ProtectSystem=full
@@ -22,11 +22,12 @@
 ProtectKernelModules=true
 ProtectKernelTunables=true
 LockPersonality=true
-RestrictRealtime=yes
-RestrictNamespaces=yes
-MemoryDenyWriteExecute=yes
-PrivateDevices=yes
+RestrictRealtime=true
+RestrictNamespaces=true
+MemoryDenyWriteExecute=true
+PrivateDevices=true
 CapabilityBoundingSet=
 
 [Install]
 WantedBy=multi-user.target