adding pytest coverage

pyproject.toml

@@ -30,3 +30,4 @@ cryptography = "^43.0.3"
 ipykernel = "^6.29.4"
 freezegun = "^1.5.1"
 pytest = "^8.3.2"
+pytest-cov = "^6.0.0"

src/apn.py

@@ -38,15 +38,28 @@ def send_push_notification(device_token: str, title: str, body: str):
     :param device_token: User's device token
     :param title: Notification title
     :param body: Notification body
+    :raises ValueError: If device token is invalid
     """
+    # Validate device token format
+    clean_token = device_token.strip().replace(" ", "")
+    if (
+        not clean_token
+        or len(clean_token) != 64
+        or not all(c in "0123456789abcdefABCDEF" for c in clean_token)
+    ):
+        raise ValueError(f"Invalid device token format: {device_token}")
+
+    logging.info(
+        f"Sending push notification with token: {clean_token[:8]}..."
+    )  # Log first 8 chars for debugging
+
     auth_token = generate_jwt_token(
         key_id=os.environ["APN_KEY_ID"],
         team_id=os.environ["APN_TEAM_ID"],
         private_key=base64.b64decode(os.environ["APN_PRIVATE_KEY"]).decode(),
     )
 
     base_url = "api.push.apple.com"
-    clean_token = device_token.strip().replace(" ", "")
     url = f"https://{base_url}/3/device/{clean_token}"
     headers = {
         "Authorization": f"Bearer {auth_token}",
@@ -78,12 +91,19 @@ def send_push_notification(device_token: str, title: str, body: str):
 
 
 def send_push_notif_wrapper(user: UserRow):
+    """Send push notification to user if they have a valid device token."""
     user_auth = get_user_auth(user.athlete_id)
-    if user_auth.device_token:
+    if not user_auth.device_token:
+        logger.info(f"No device token for user {user.athlete_id}")
+        return
+
+    try:
         send_push_notification(
             device_token=user_auth.device_token,
             title="TrackFlow 🏃‍♂️🎯",
             body="Your training week has been updated!",
         )
-    else:
-        logger.info(f"Skipping push notification for {user.athlete_id=}")
+    except ValueError as e:
+        logger.error(f"Invalid device token for user {user.athlete_id}: {e}")
+    except Exception as e:
+        logger.error(f"Failed to send push notification to user {user.athlete_id}: {e}")

src/auth_manager.py

@@ -147,14 +147,11 @@ def authenticate_with_code(code: str) -> UserAuthRow:
 
 def signup(user_auth: UserAuthRow, email: Optional[str] = None) -> dict:
     """ """
-    preferences = (
-        "I'm looking to improve my running performance while being smart and realistic."
-    )
     send_alert_email(
         subject="TrackFlow Alert: New Signup Attempt",
-        text_content=f"You have a new client {email=} attempting to signup with {preferences=}",
+        text_content=f"You have a new client {email=} attempting to signup",
     )
-    upsert_user(UserRow(athlete_id=user_auth.athlete_id, preferences=preferences))
+    upsert_user(UserRow(athlete_id=user_auth.athlete_id))
     return {"success": True, "jwt_token": user_auth.jwt_token, "is_new_user": True}
 
 

src/frontend_router.py

@@ -3,7 +3,7 @@
 import jwt
 
 from src import auth_manager
-from src.activities import get_daily_activity, get_weekly_summaries
+from src.activities import get_weekly_summaries
 from src.auth_manager import get_strava_client
 from src.supabase_client import (
     get_training_week,
@@ -36,7 +36,7 @@ def get_profile_handler(athlete_id: str, payload: dict) -> dict:
             "lastname": athlete.lastname,
             "profile": athlete.profile,
             "email": user.email,
-            "preferences": user.preferences_json.json(),
+            "preferences": user.preferences.json(),
         },
     }
 
@@ -45,7 +45,7 @@ def update_preferences_handler(athlete_id: str, payload: dict) -> dict:
     """Handle update_preferences request."""
     if payload is None or "preferences" not in payload:
         return {"success": False, "error": "Missing preferences in payload"}
-    update_preferences(athlete_id=athlete_id, preferences_json=payload["preferences"])
+    update_preferences(athlete_id=athlete_id, preferences=payload["preferences"])
     return {"success": True}
 
 

src/supabase_client.py

@@ -158,22 +158,22 @@ def upsert_training_week(
     return response
 
 
-def update_preferences(athlete_id: int, preferences_json: dict) -> APIResponse:
+def update_preferences(athlete_id: int, preferences: dict) -> APIResponse:
     """
     Update user's preferences
 
     :param athlete_id: The ID of the athlete
-    :param preferences: json string representing a Preferences object
+    :param preferences: A Preferences object as a dictionary
     :return: APIResponse
     """
     try:
-        Preferences(**preferences_json)
+        Preferences(**preferences)
     except Exception as e:
         raise ValueError("Invalid preferences") from e
 
     table = client.table("user")
     response = (
-        table.update({"preferences_json": preferences_json})
+        table.update({"preferences": preferences})
         .eq("athlete_id", athlete_id)
         .execute()
     )

src/types/training_week.py

@@ -29,7 +29,7 @@ class TrainingSession(BaseModel):
     session_type: SessionType
     distance: float = Field(description="Distance in miles")
     notes: str = Field(
-        description="Concise notes about the session, e.g. '2x2mi @ 10k pace' or 'easy pace'"
+        description="Detailed yet concise notes about the session from the coach's perspective"
     )
     completed: bool = Field(description="Whether the session has been completed")
 

src/types/user_row.py

@@ -23,12 +23,11 @@ class TheoreticalTrainingSession(BaseModel):
 
 class Preferences(BaseModel):
     race_distance: Optional[RaceDistance] = None
-    ideal_training_week: Optional[List[TheoreticalTrainingSession]] = None
+    ideal_training_week: Optional[List[TheoreticalTrainingSession]] = []
 
 
 class UserRow(BaseModel):
     athlete_id: int
-    preferences: str
+    preferences: Optional[Preferences] = Preferences()
     email: Optional[str] = None
-    preferences_json: Optional[Preferences] = {}
     created_at: datetime = datetime.now()

src/update_pipeline.py

@@ -33,14 +33,14 @@ def update_training_week(user: UserRow, exe_type: ExeType) -> dict:
         if exe_type == ExeType.NEW_WEEK:
             weekly_summaries = get_weekly_summaries(strava_client)
             training_week = generate_new_training_week(
-                sysmsg_base=f"{COACH_ROLE}\n{user.preferences}",
+                sysmsg_base=f"{COACH_ROLE}\nClient Preferences: {user.preferences}",
                 weekly_summaries=weekly_summaries,
             )
         else:  # ExeType.MID_WEEK
             current_week = get_training_week(user.athlete_id)
             activity_summaries = get_activity_summaries(strava_client, num_weeks=1)
             training_week = generate_mid_week_update(
-                sysmsg_base=f"{COACH_ROLE}\n{user.preferences}",
+                sysmsg_base=f"{COACH_ROLE}\nClient Preferences: {user.preferences}",
                 training_week=current_week,
                 completed_activities=activity_summaries,
             )