Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AV-2184: Use a thread pool instead of CKAN jobs for sending events #53

Merged
merged 2 commits into from
Apr 16, 2024
Merged

AV-2184: Use a thread pool instead of CKAN jobs for sending events #53

merged 2 commits into from
Apr 16, 2024

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Apr 16, 2024

  • Added tracking_bulk to MatomoAPI for sending multiple events with one request
  • Converted matomo_track and post_analytics to send events using a Queue and a ThreadPool instead of leveraging CKAN job system

@coveralls
Copy link

coveralls commented Apr 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8702749757

Details

  • 8 of 40 (20.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 40.983%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext/matomo/matomo_api.py 2 9 22.22%
ckanext/matomo/tracking.py 6 31 19.35%
Totals Coverage Status
Change from base Build 8685089269: -0.3%
Covered Lines: 609
Relevant Lines: 1486
💛 - Coveralls

@bzar bzar merged commit 0dd7bad into main Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zharktas Zharktas Zharktas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzar @coveralls @Zharktas