-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Styleguidist overhaul #766
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riippi
reviewed
Aug 23, 2023
Riippi
reviewed
Aug 23, 2023
Riippi
reviewed
Aug 23, 2023
jenkrisu
reviewed
Aug 25, 2023
jenkrisu
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 25, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
reviewed
Aug 28, 2023
danielck
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jolly good!
WIP: Facelift Styleguidist component pages improve WizardNavigation documentation page improve VisuallyHidden documentation improve tooltip documentation page WIP: Facelift Styleguidist component pages update ToggleInput and ToggleButton documentation improve toast documentation page improve TextInput documentation page improve textarea documentation page improve textinput example content WIP: Facelift Styleguidist component pages improve texarea examples improve text and paragraph documentation pages improve statustext documentation page WIP: Facelift Styleguidist component pages
Styleguidist: Change links to markdown format Adjust component docs Adjust Expander docs Adjust Breadcrumb docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Breadcrumb docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Expander docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Expander docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Expander docs Adjust Checkbox docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Checkbox docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Checkbox docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Checkbox docs Adjust Link docs Adjust TextInput docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Toggle docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust LanguageMenu docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Link docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Modal docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com> Adjust Modal docs Co-authored-by: Daniel Koskinen <daniel.koskinen@gofore.com>
riitasointi
force-pushed
the
feature/documentation-improvements
branch
from
August 30, 2023 10:21
8b3c82d
to
823f2e8
Compare
Riippi
approved these changes
Sep 4, 2023
This was referenced Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR includes a thorough overhaul to the Styleguidist component pages. Examples are improved throughout and links are provided at the top of the page to quickly navigate to different sections as well as the props list.
Motivation and Context
We want our documentation to be coherent and consistent, and provide good examples as well as accessibility information.
Release notes
General