[Feature] ConfigProvider and AutoID prefix #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
force-pushed
the
feature/auto-id-identifier
branch
from
ff3d0cf to
0cc6de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new HOC to the library,
ConfigProvider. At this point it is used to give the user the option to give the internal AutoID utility a custom prefix to use in the generated IDs. In the future it can be expanded to be used for other global settings for the library.Motivation and Context
The AutoID prefix feature was requested by a project, and the ConfigProvider seemed like the best way to implement that.
How Has This Been Tested?
So far tested by running locally in styleguidist and wrapping components in the provider
Release notes
ConfigProvider
ConfigProviderHOC. Can currently be used to give a custom prefix for autogenerated IDs of its children