fixed ambiguous overload

vshaxe · Jan 4, 2025 · 94d81b6 · 94d81b6
1 parent 0e1055f
commit 94d81b6
Showing 1 changed file with 22 additions and 25 deletions.
diff --git a/src/Vscode.hx b/src/Vscode.hx
@@ -667,6 +667,7 @@ extern class VscodeWindow {
 	 */
 	function createTextEditorDecorationType(options:DecorationRenderOptions):TextEditorDecorationType;
 
+
 	/**
 	 * Show an information message to users. Optionally provide an array of items which will be presented as
 	 * clickable buttons.
@@ -675,7 +676,16 @@ extern class VscodeWindow {
 	 * @param items A set of items that will be rendered as actions in the message.
 	 * @returns A thenable that resolves to the selected item or `undefined` when being dismissed.
 	 */
-	overload function showInformationMessage(message:String, items:Rest<String>):Thenable<Null<String>>;
+	// /**
+	//  * Show an information message.
+	//  *
+	//  * @see {@link window.showInformationMessage showInformationMessage}
+	//  *
+	//  * @param message The message to show.
+	//  * @param items A set of items that will be rendered as actions in the message.
+	//  * @returns A thenable that resolves to the selected item or `undefined` when being dismissed.
+	//  */
+	overload function showInformationMessage<T:EitherType<String, MessageItem>>(message:String, items:Rest<T>):Thenable<Null<T>>;
 
 	/**
 	 * Show an information message to users. Optionally provide an array of items which will be presented as
@@ -686,30 +696,17 @@ extern class VscodeWindow {
 	 * @param items A set of items that will be rendered as actions in the message.
 	 * @returns A thenable that resolves to the selected item or `undefined` when being dismissed.
 	 */
-	overload function showInformationMessage(message:String, options:MessageOptions, items:Rest<String>):Thenable<Null<String>>;
-
-	/**
-	 * Show an information message.
-	 *
-	 * @see {@link window.showInformationMessage showInformationMessage}
-	 *
-	 * @param message The message to show.
-	 * @param items A set of items that will be rendered as actions in the message.
-	 * @returns A thenable that resolves to the selected item or `undefined` when being dismissed.
-	 */
-	overload function showInformationMessage<T:MessageItem>(message:String, items:Rest<T>):Thenable<Null<T>>;
-
-	/**
-	 * Show an information message.
-	 *
-	 * @see {@link window.showInformationMessage showInformationMessage}
-	 *
-	 * @param message The message to show.
-	 * @param options Configures the behaviour of the message.
-	 * @param items A set of items that will be rendered as actions in the message.
-	 * @returns A thenable that resolves to the selected item or `undefined` when being dismissed.
-	 */
-	overload function showInformationMessage<T:MessageItem>(message:String, options:MessageOptions, items:Rest<T>):Thenable<Null<T>>;
+	// /**
+	//  * Show an information message.
+	//  *
+	//  * @see {@link window.showInformationMessage showInformationMessage}
+	//  *
+	//  * @param message The message to show.
+	//  * @param options Configures the behaviour of the message.
+	//  * @param items A set of items that will be rendered as actions in the message.
+	//  * @returns A thenable that resolves to the selected item or `undefined` when being dismissed.
+	//  */
+	overload function showInformationMessage<T:EitherType<String, MessageItem>>(message:String, options:MessageOptions, items:Rest<T>):Thenable<Null<T>>;
 
 	/**
 	 * Show a warning message.