Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-multiple-template-root): support disallowComments property #2685

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(no-multiple-template-root): support disallowComments property #2685

wants to merge 6 commits into from

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Feb 14, 2025 •
edited
Loading

Issue

close #2316

@chouchouji
Copy link
Contributor Author

chouchouji commented Feb 14, 2025 •
edited
Loading

@FloEdelmann I am confused about how to determine if it is the comment of the root node. So I choose to filter invalid comments by node ranges. If you have better idea, please tell me. Thanks!

<template>
  <!-- this is a comment --> // should report
   <div>
       123
       <!-- this is a comment --> // should not report
   </div>
   <!-- this is a comment --> // should report
</template>

@chouchouji chouchouji force-pushed the feat-disallow-comments branch 2 times, most recently from d93ffe2 to 0cd3dff Compare February 15, 2025 07:58
@ota-meshi ota-meshi marked this pull request as draft March 5, 2025 04:48
@chouchouji chouchouji force-pushed the feat-disallow-comments branch from 0cd3dff to d2f906f Compare March 5, 2025 06:35
@chouchouji chouchouji marked this pull request as ready for review March 5, 2025 06:48
@chouchouji
Copy link
Contributor Author

@ota-meshi I updated docs and test cases. Please review it if you have time. Thanks.

ota-meshi
ota-meshi requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@chouchouji
Copy link
Contributor Author

Thank you for this PR!

Thanks for your review. I updated code and test cases.

@chouchouji chouchouji force-pushed the feat-disallow-comments branch from 979a728 to e6bc9d0 Compare March 5, 2025 08:39
@chouchouji chouchouji force-pushed the feat-disallow-comments branch from e6bc9d0 to 7dcd683 Compare March 5, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/no-multiple-template-root false negative with comment
2 participants
@chouchouji @ota-meshi