Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few small changes to improve readability #32

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Conversation

gosko
Copy link
Member

@gosko gosko commented Mar 9, 2018

Hi, the mockup-rwd design is looking pretty good, nice work!

I find it a little bit difficult to read, maybe because there are so many font styles? I did some experimenting with the style, please let me know what you think.

screen shot 2018-03-08 at 6 00 32 pm

I made a few small changes to the HTML as well as the CSS:

  • replaced "Published on" with a class name
  • removed emphasis from "Editor's Draft", and moved that to the same line as "History"
  • added an   between words in 'Level 1', to avoid the 1 getting wrapped onto a line of its own (maybe there is a smarter way to do this using CSS instead of  )

@tripu tripu self-assigned this Mar 9, 2018
@tripu tripu added enhancement Something could be improved (as opposed to “doesn't work as it should”) mock-up-1 About our first iteration (released ~ 20 Mar 2018) labels Mar 9, 2018
@gosko gosko changed the base branch from mockup-rwd to master March 9, 2018 16:00
@tripu
Copy link
Member

tripu commented Mar 13, 2018

@gosko: care to rebase your branch, to better examine the diff (mockup1/index.html has lots of changes)? Or I can do that myself; there are no conflicts, so it's immediate.

@tripu
Copy link
Member

tripu commented Mar 13, 2018

Thanks!

@gosko
Copy link
Member Author

gosko commented Mar 13, 2018

@tripu sure, done (I hope!)

@gosko gosko mentioned this pull request Mar 15, 2018
@tripu
Copy link
Member

tripu commented Mar 16, 2018

@deniak, these changes look good to me.

  • The first two require small changes on your side. Are you okay with those?
  • The 3rd is low-priority, I think, and it also has to be implemented server-side. It can wait, as we agreed.

Some of these changes clash with my own in #50; but since this PR was first, I'll take care of merging @gosko's changes with mine.

@tripu tripu assigned deniak and unassigned tripu Mar 16, 2018
@deniak deniak merged commit fbcbcda into master Mar 19, 2018
@deniak
Copy link
Member

deniak commented Mar 19, 2018

Thanks @gosko! @tripu feel free to rebase onto master.

@deniak
Copy link
Member

deniak commented Mar 19, 2018

Ok, it'll all integrated and will be deployed soon. I think I managed to add the   too when it's necessary.

@tripu tripu deleted the mockup-rwd-ger branch March 19, 2018 15:18
@gosko
Copy link
Member Author

gosko commented Mar 20, 2018

Hi again @deniak @tripu, I just saw the new version on https://www.w3.org/TR/ and noticed it is missing a few of the changes I suggested; was that deliberate or an oversight?

screen shot 2018-03-20 at 12 30 14 pm

In particular, I am not a fan of the large font and small line-height used in the spec titles. Also I prefer a less bold font and less padding in the spec maturity labels, but that is fairly minor.

If there is a better way to contribute patches just let me know :)

@deniak
Copy link
Member

deniak commented Mar 21, 2018

@gosko yes, we deployed the new version yesterday but there are more "minor" updates coming up. Regarding the changes you suggested, I'm not sure about their status. #50 was conflicting with it so maybe some rules in the CSS were missed during the rebase. @tripu should be able to answer.

About the font size of the title, I agree with you. It looks quite big compared to the rest of the details. @tripu @tanyeah WDYT?

@tripu
Copy link
Member

tripu commented Mar 23, 2018

@gosko, @deniak: Yes, #50 changed the markup a bit (and its classes); I had to solve some conflicts when rebasing to be able to merge. Some of @gosko's changes were made obsolete by my own, but I may have broken others inadvertently 😕

So, part deliberate, part oversight…

@gosko, issues and PRs here is the right way! Thank you! Don't give up on us! :)

I'm OK reducing the font size and weight of spec titles, and increasing the line height.

I think I'll submit a new PR with those changes, plus some of what @gosko suggested here: #44 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something could be improved (as opposed to “doesn't work as it should”) mock-up-1 About our first iteration (released ~ 20 Mar 2018)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants