-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few small changes to improve readability #32
Conversation
@gosko: care to rebase your branch, to better examine the diff ( |
Thanks! |
@tripu sure, done (I hope!) |
@deniak, these changes look good to me.
Some of these changes clash with my own in #50; but since this PR was first, I'll take care of merging @gosko's changes with mine. |
Ok, it'll all integrated and will be deployed soon. I think I managed to add the |
Hi again @deniak @tripu, I just saw the new version on https://www.w3.org/TR/ and noticed it is missing a few of the changes I suggested; was that deliberate or an oversight? In particular, I am not a fan of the large font and small line-height used in the spec titles. Also I prefer a less bold font and less padding in the spec maturity labels, but that is fairly minor. If there is a better way to contribute patches just let me know :) |
@gosko yes, we deployed the new version yesterday but there are more "minor" updates coming up. Regarding the changes you suggested, I'm not sure about their status. #50 was conflicting with it so maybe some rules in the CSS were missed during the rebase. @tripu should be able to answer. About the font size of the title, I agree with you. It looks quite big compared to the rest of the details. @tripu @tanyeah WDYT? |
@gosko, @deniak: Yes, #50 changed the markup a bit (and its classes); I had to solve some conflicts when rebasing to be able to merge. Some of @gosko's changes were made obsolete by my own, but I may have broken others inadvertently 😕 So, part deliberate, part oversight… @gosko, issues and PRs here is the right way! Thank you! Don't give up on us! :) I'm OK reducing the font size and weight of spec titles, and increasing the line height. I think I'll submit a new PR with those changes, plus some of what @gosko suggested here: #44 (comment)… |
Hi, the mockup-rwd design is looking pretty good, nice work!
I find it a little bit difficult to read, maybe because there are so many font styles? I did some experimenting with the style, please let me know what you think.
I made a few small changes to the HTML as well as the CSS: