Add non confirming processors #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aljones15
commented
Jul 10, 2024
aljones15
commented
- asserts on 400 or 422
- moves a test data gen from suite to setup
- adds missing normative statement
BigBlueHat
approved these changes
Jul 10, 2024
tests/assertions.js
Outdated
| 400, | ||
| 'Expected HTTP Status code 400 invalid input!' | ||
| ); | ||
| error.status.should.be.oneOf([400, 422], reason); |
There was a problem hiding this comment.
Should this reason be something closer to the original rather than "Expected no result from verifier."?
There was a problem hiding this comment.
hmmmm... I honestly was just thinking about the single case here where Greg's implementation runs 500 and I didn't know which test vector was causing that, so I think having a different default makes sense and I'll make that change momentarily. good idea.
There was a problem hiding this comment.
added the additional default here f1fbfad
aljones15
force-pushed
the
add-non-confirming-processors
branch
from
9c6de82 to
f1fbfad
Compare
|
This should be retitled to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.