Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve VideoFrame.copyTo with the list of layout #738

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Resolve VideoFrame.copyTo with the list of layout #738

merged 1 commit into from
Nov 3, 2023

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented Oct 31, 2023 •
edited by pr-preview bot
Loading

This fixes #510.

Preview | Diff

@padenot padenot requested review from Djuffin and aboba October 31, 2023 14:32
Djuffin
Djuffin approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Djuffin Djuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Safari and Chromium do it this way. It should be a part of the spec.

@Djuffin Djuffin merged commit 072c8e5 into main Nov 3, 2023
@Djuffin Djuffin deleted the 510-resolve-planes branch November 3, 2023 00:36
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
74f5ea1 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
c45d0ea 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
6f5b60e 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
171023c 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
3db0a63 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
34867b6 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
5988898 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
98d8497 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
0792b78 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
9333577 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
7460bf2 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
e9135f7 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
38c717f 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
ac5fa0b 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
14cc801 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 3, 2023
@Djuffin @github-actions
Merge pull request #738 from w3c/510-resolve-planes
885e5d5 
SHA: 072c8e5
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@padenot
Copy link
Collaborator Author

padenot commented Nov 3, 2023

Both Safari and Chromium do it this way. It should be a part of the spec.

It was part of the spec, it was clear from the signature all along, but we forgot to resolve with the value when writing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Djuffin Djuffin Djuffin approved these changes

@aboba aboba Awaiting requested review from aboba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VideoFrame.copyTo doesn't resolve its Promise with a value
2 participants
@padenot @Djuffin