Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orientation metadata to VideoDecoderConfig, update algorithms #874

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

dalecurtis
Copy link
Contributor

@dalecurtis dalecurtis commented Jan 27, 2025

As proposed on the issue and discussed in WG, this does the following:

  • Adds rotation/flip fields to VideoDecoderConfig.
  • Updates the "Create a VideoFrame" algorithm used by the video and image decoders to accept these fields.
  • Updates the video and image decoding algorithms to provide these fields during decoding.

Bug: #351


Preview | Diff

@dalecurtis dalecurtis requested review from Djuffin and padenot January 27, 2025 23:59
@dalecurtis
Copy link
Contributor Author

Hmm, I can't seem to rebase this to pass the checks, but there are no failures in this change after my other fixes AFAICT.

@Djuffin
Copy link
Contributor

Djuffin commented Jan 28, 2025

This PR is still 2 commits behind main
see here

try rebasing decode_spec branch

As proposed on the issue and discussed in WG, this does the following:
- Adds rotation/flip fields to VideoDecoderConfig.
- Updates the "Create a VideoFrame" algorithm used by the video
and image decoders to accept these fields.
- Updates the video and image decoding algorithms to provide
these fields during decoding.

Bug: #351
@dalecurtis
Copy link
Contributor Author

CLI rebase required me to use --force to push, but per chat that seems to be the way to go. Should be ready to go now.

index.src.html Show resolved Hide resolved
index.src.html Outdated Show resolved Hide resolved
@dalecurtis dalecurtis requested a review from Djuffin January 29, 2025 00:48
@dalecurtis dalecurtis merged commit 90090dc into main Jan 29, 2025
2 checks passed
@dalecurtis dalecurtis deleted the decode_spec branch January 29, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants