Andrews pop version #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All issues should be handled from check list from the following issue: Bandersnatch left empty let me know if this is ok for now.. |
Co-authored-by: drskalman <35698397+drskalman@users.noreply.github.com>
Co-authored-by: drskalman <35698397+drskalman@users.noreply.github.com>
…/polkadot-sdk into crypto_feature_issues_andrew
Crypto feature issues andrew
drskalman
approved these changes
Feb 1, 2025
|
Review required! Latest push from author must always be reviewed |
coax1d
changed the base branch from
skalman--proof-of-possession-for-all-cryptos
to
andrew-testing-correct-syed-pop
coax1d
changed the base branch from
andrew-testing-correct-syed-pop
to
skalman--proof-of-possession-for-all-cryptos
coax1d
changed the base branch from
skalman--proof-of-possession-for-all-cryptos
to
andrew-testing-correct-syed-pop
drskalman
reviewed
Feb 4, 2025
drskalman
reviewed
Feb 4, 2025
drskalman
reviewed
Feb 4, 2025
drskalman
reviewed
Feb 4, 2025
coax1d
changed the base branch from
andrew-testing-correct-syed-pop
to
skalman--proof-of-possession-for-all-cryptos
coax1d
merged commit 59ce3e6
into
skalman--proof-of-possession-for-all-cryptos
41 of 49 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✄ -----------------------------------------------------------------------------
Thank you for your Pull Request! 🙏 Please make sure it follows the contribution guidelines outlined in this
document and fill out the
sections below. Once you're ready to submit your PR for review, please delete this section and leave only the text under
the "Description" heading.
Description
A concise description of what your PR is doing, and what potential issue it is solving. Use Github semantic
linking
to link the PR to an issue that must be closed once this is merged.
Integration
In depth notes about how this PR should be integrated by downstream projects. This part is mandatory, and should be
reviewed by reviewers, if the PR does NOT have the
R0-Silentlabel. In case of aR0-Silent, it can be ignored.Review Notes
In depth notes about the implementation details of your PR. This should be the main guide for reviewers to
understand your approach and effectively review it. If too long, use
<details>.Imagine that someone who is depending on the old code wants to integrate your new code and the only information that
they get is this section. It helps to include example usage and default value here, with a
diffcode-block to showpossibly integration.
Include your leftover TODOs, if any, here.
Checklist
Trequired)You can remove the "Checklist" section once all have been checked. Thank you for your contribution!
✄ -----------------------------------------------------------------------------