unwarp Results #46
unwarp Results #46
Conversation
There was a problem hiding this comment.
As far as i remember, the only Err possible is if the polynomial being committed is inconsistent with the SRS (e.g. for the KZG case, the poly degree is >> the SRS size). So i find it reasonable just to unwrap the Errs.
Well, this is correct as far as the code assumes to know what PCS implementation the user decided to use. If he plugs a PCS that fails for other reasons that this unwrap may just panic.
IMHO it is also not ideal to return a Result from methods like PlonkProver::prove.
So maybe we can at least be explicit in the method docs that these methods panics if PCS::commit fails
| @@ -11,5 +11,5 @@ ark-ff = { version = "0.5", default-features = false } | |||
| ark-ec = { version = "0.5", default-features = false } | |||
| ark-poly = { version = "0.5", default-features = false } | |||
| ark-serialize = { version = "0.5", default-features = false, features = ["derive"] } | |||
| fflonk = { git = "https://github.com/w3f/fflonk", default-features = false } | |||
| fflonk = { git = "https://github.com/w3f/fflonk", branch="return-result", default-features = false } | |||
There was a problem hiding this comment.
I guess you can merge fflonk return-result branch already? So you don't need to target this branch here
As far as i remember, the only Err possible is if the polynomial being committed is inconsistent with the SRS (e.g. for the KZG case, the poly degree is >> the SRS size). So i find it reasonable just to unwrap the Errs.