fix(tests): peer-exchange interop #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
danisharora099
force-pushed
the
fix/peer-exchange-interop-test
branch
from
12b1a1d to
1ab3d58
Compare
2 tasks
danisharora099
commented
Jan 8, 2024
weboko
reviewed
Jan 8, 2024
danisharora099
force-pushed
the
fix/peer-exchange-interop-test
branch
from
37f070f to
dca2f6e
Compare
weboko
reviewed
Jan 10, 2024
| peerInfos.find( | ||
| ({ ENR }) => ENR?.peerInfo?.id.toString() === nwaku1PeerId.toString() | ||
| ) !== undefined; | ||
| peerInfos.find(({ ENR }) => { |
There was a problem hiding this comment.
I would not use .find in that case and would use .forEach since side effects important so that presence of foundNodePeerId is the result.
There was a problem hiding this comment.
changed it to use some which seems more appropriate & efficient
weboko
reviewed
Jan 10, 2024
adklempner
approved these changes
Jan 10, 2024
weboko
reviewed
Jan 10, 2024
| ({ ENR }) => ENR?.peerInfo?.id.toString() === nwaku1PeerId.toString() | ||
| ) !== undefined; | ||
| const foundNodeMultiaddrs: Multiaddr[] = []; | ||
| const foundNodePeerId: PeerId | undefined = undefined; |
There was a problem hiding this comment.
these values never get set, so that it will always throw at :87 and if not it will dial empty maddrs array
There was a problem hiding this comment.
haha, you're right which is why the test failed as well. this caught in during the refactor from find to some -- addressed this -- thanks! :)
There was a problem hiding this comment.
merging this PR now, let me know if you want to suggest any other change & I can follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current peer-exchange interop test does not correctly test the functionality
Solution