fix: allow autosharding nodes to get peers #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
weboko
approved these changes
Jan 12, 2024
danisharora099
requested changes
Jan 16, 2024
adklempner
force-pushed
the
fix/autosharding-peers
branch
2 times, most recently
from
74b3c64 to
7a18dc3
Compare
adklempner
force-pushed
the
fix/autosharding-peers
branch
from
7a18dc3 to
c897ee6
Compare
|
@danisharora099 added test cases for getPeers with js-waku configured for autosharding |
danisharora099
approved these changes
Jan 17, 2024
danisharora099
merged commit 4dd451b
into
feat/shard-peer-selection
8 of 10 checks passed
danisharora099
added a commit
that referenced
this pull request
Jan 19, 2024
* merge: master * fix: tests * update: interfafces * rm: comments * metadata: store peerIdStr instead of peerId * chore(utils): move fast-utils to dev deps * fix: allow autosharding nodes to get peers (#1785) * fix: merge * fix: build * fix: failing tests from master merge --------- Co-authored-by: Arseniy Klempner <arseniyk@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Fixes some failing tests in #1756 and stops throwing errors if node is setup to use autosharding
Notes