Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable auto start upon node creation #2291

Merged
merged 2 commits into from
Feb 27, 2025
Merged

feat: enable auto start upon node creation #2291

merged 2 commits into from
Feb 27, 2025

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Feb 26, 2025

Problem / Description

Developers need to explicitly call node.start but can forget to do so sometimes.

Solution

Add autoStart option.

Notes


Checklist

N/A

@weboko weboko requested a review from a team as a code owner February 26, 2025 23:28
Copy link

github-actions bot commented Feb 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 85.1 KB (-0.1% 🔽) 1.8 s (-0.1% 🔽) 544 ms (+33.42% 🔺) 2.3 s
Waku Simple Light Node 136.14 KB (+0.06% 🔺) 2.8 s (+0.06% 🔺) 622 ms (-0.17% 🔽) 3.4 s
ECIES encryption 22.92 KB (0%) 459 ms (0%) 266 ms (+0.69% 🔺) 725 ms
Symmetric encryption 22.35 KB (0%) 447 ms (0%) 243 ms (-3.66% 🔽) 690 ms
DNS discovery 70.85 KB (0%) 1.5 s (0%) 476 ms (-8.1% 🔽) 1.9 s
Peer Exchange discovery 71.85 KB (0%) 1.5 s (0%) 527 ms (+67.35% 🔺) 2 s
Local Peer Cache Discovery 65.36 KB (0%) 1.4 s (0%) 504 ms (+22.1% 🔺) 1.9 s
Privacy preserving protocols 76.63 KB (0%) 1.6 s (0%) 492 ms (-26.14% 🔽) 2.1 s
Waku Filter 78.3 KB (0%) 1.6 s (0%) 436 ms (-32.34% 🔽) 2.1 s
Waku LightPush 75.76 KB (0%) 1.6 s (0%) 548 ms (+21.03% 🔺) 2.1 s
History retrieval protocols 75.87 KB (0%) 1.6 s (0%) 440 ms (-27.28% 🔽) 2 s
Deterministic Message Hashing 7.33 KB (0%) 147 ms (0%) 120 ms (+50.77% 🔺) 267 ms

@weboko weboko merged commit 09108d9 into master Feb 27, 2025
10 of 11 checks passed
@weboko weboko deleted the weboko/auto-start branch February 27, 2025 13:00
@weboko weboko mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: enable auto start upon node creation
2 participants