test: test_wakunode_rln_relay use waitForNullifierLog in all tests avoid flaky #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 8cfb906 |
Ivansete-status
force-pushed
the
fix-rln-flaky-test
branch
from
9c0bf09 to
fe50cdb
Compare
Ivansete-status
requested review from
darshankabariya,
gabrielmer and
NagyZoltanPeter
darshankabariya
approved these changes
Jan 6, 2025
NagyZoltanPeter
approved these changes
Jan 6, 2025
This test is pretty annoying and I have the impression that these tests may complain in the nearby future and this is why it may help us to debug. I just created a reminder for next month and we can check if we can clean it up. Also maybe it can be interesting what is the average wait time needed for nullifier logs. WDYT? Yes this would be interesting to measure but not for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend @darshankabariya 's approach to all tests to avoid RLN flaky tests at any point