-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update lightclient examples to use waku prod fleet and readme #3237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intent is good, to keep examples working out of the box.
But I think wakuv2.prod was about to be decommissioned, and if you check the fleets.waku.org info board it is abandoned. The bootstrap version is pretty old, v0.24.0, instead of v0.34.0 - the current latest.
I would recommend waku-sandbox maybe as a better option - although that has rln as being connected with TWN if I'm right.
Also I think at some point we shall invest some time in enhancing these examples as they are way too simple and don't give the feeling of real application needs and possibilities.
In this example using the same service peer for filter and lightpush is just not what a normal light client should do.
@Ivansete-status WDYT?
31cb109
to
a8c6765
Compare
I have updated the code with sandbox fleet and it seems to work consistentnly. I have tried to use a different node from fleet for subscriber and publisher but noticed that DIAL fails and hence left using same node for both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for it! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
@NagyZoltanPeter any other changes would you like to have or can i merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, all good! Thanks for it.
No, you can go of course! |
Description
While running lightpush and filter examples connectivity to peers was failing. Realized that metadata is not mounted and hence connectivity keeps failing randomly.
Updating the same to mount metadata and also use waku sandbox fleet.
Thanks @richard-ramos for helping with this.
Note that i had specified default shard as 0 and clusterID as 1 for metadata support to work. But this is not ideal, maybe we should have a way for the user to not specify shards and just use autosharding API.
Changes