chore: adding extra migration to sqlite and improving error message

[gabrielmer]

Description

Waku Archive with sqlite was broken, as our table required a storedAt column being not null, and we are not using that column anymore, so insert statements were failing.

The tests didn't catch the issue because migrations weren't executed before the tests, so the tests were run with a db schema that wasn't the one our nodes were using in practice.

Fixed issue executing insert statements and modified tests in order to catch similar issues in the future

Changes

• added migration script for sqlite's Waku Archive that replaces the storedAt column with timestamp
• start running migrations before tests, so tests are executed with correct db schema
• improved error message

Issue

#3236

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3240

Built from 8b6a435

[gabrielmer]

Copying the following migration we do for Postgres:

nwaku/migrations/message_store_postgres/content_script_version_6.nim

Lines 3 to 7 in 625c8ee

	-- we can drop the timestamp column because this data is also kept in the storedAt column
	ALTER TABLE messages DROP COLUMN timestamp;
	-- from now on we are only interested in the message timestamp
	ALTER TABLE messages RENAME COLUMN storedAt TO timestamp;

[Ivansete-status]

Awesome! Thanks for it! 💯

[NagyZoltanPeter]

LGTM! Thank you!

[richard-ramos]

Oh this is cool.
I thought renaming columns in sqlite wasn't possible but required creating a new table with the new column name and migrating the data from the old table to the new one!
Is this a feature that was added recently? (for sure it would be useful even for status since there we do the 'manual' renaming procedure i mentioned).

[gabrielmer]

Good question! Not sure if it's a recent honestly, I just copied it from the migration script we use in postgres and it worked lol

It does seem it's a feature supported by sqlite: https://www.sqlitetutorial.net/sqlite-rename-column/

update: the article does say "SQLite did not support the ALTER TABLE RENAME COLUMN syntax before version 3.25.0."

[richard-ramos]

This was introduced in 2018! wow!