Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dbconn truncate possible too long error messages #3283

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

Ivansete-status
Copy link
Collaborator

Description

libpq sometimes gives extremly long error messages. This PRs limits that

Issue

closes #3282

Copy link

github-actions bot commented Feb 6, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3283

Built from c5a3acf

@Ivansete-status Ivansete-status marked this pull request as ready for review February 6, 2025 16:39
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ivansete-status Ivansete-status merged commit 9a8e1ef into master Feb 7, 2025
10 of 12 checks passed
@Ivansete-status Ivansete-status deleted the limit-error-msg-store branch February 7, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: waku_store_errors_created metrics puts whole errors into labels
3 participants