Tristan/war 529 deep sylow optimization #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WAR-529 Deep sylow optimization
SIMD vectorized computations using dimensionals? Hand rolled finite field from organic heirloom tobacco? Seriously though, we can come up for air after WAR-540 and decide what's in or out of scope or needed to beat bn and become the defacto bn128 implementation in rust. |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
* [wip] first pass at framing arithmetic * [wip] mult madness * added some docs * r * interface from noether (#11) * chore: bring in template * fmt * [wip] added egcd --------- Co-authored-by: Tristan Britt <tristan.britt@mail.mcgill.ca> Co-authored-by: Tristan Britt <53545754+trbritt@users.noreply.github.com>
|
@trbritt are we ever proceeding w this in our 80/20 time or should we close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements basic multi-precision integer arithmetic on the base field to begin totally removing the crypto_bigint dependency.
NOTE this is entirely standalone, as in only +, -, x, /, have been implemented but not integrated, aka you cannot just switch these two just yet, since there are methods like exp, sqrt, etc, that must still be implemented.
The division leaves much to be desired, and must be cleaned up and tightened heavily, as it curently does arithmetic in non-modular and modular forms.
Accuracy tests are written for basic stuff, and the full verification will come when we fully switch out crypto_bigint for these modules, since
fp.rshas enough rigorous tests defined to verify the accuracy and speed of thescalar.rs.