tristan/war-628-sylow-revm-precompile-compatability #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAlcibiades
approved these changes
Sep 6, 2024
trbritt
deleted the
tristan/war-628-sylow-revm-precompile-compatability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the necessary changes for being able to replace
bn128.rsinrethwhich currently performs the bn254 arithmetic viabn, and includes the actual code to copy paste into reth in order to do it.biggest feature change is makinthe batch pairing public, as well as taking into account the fact that reth / geth expect the serialization of points at infinity to be
[0u64; 64], which is not technically precise, but nonetheless is the expection. the result of that is the addition of a new methodto_be_bytes_scrubbedthat handles this case of the point at infinity.