Use updated logging macro. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Use updated logging macro ([#4](https://github.com/warpdotdev/sentry-cocoa/pull/4))If none of the above apply, you can opt out of this check by adding |
alokedesai
reviewed
Oct 29, 2024
| @@ -321,10 +321,12 @@ handleExceptions(void *const userData) | |||
| break; | |||
| } | |||
|
|
|||
| SentryCrashLOG_DEBUG("Received exception from subprocess. Ignoring message and waiting for another."); | |||
| SENTRY_ASYNC_SAFE_LOG_DEBUG( | |||
There was a problem hiding this comment.
Assuming this is the only actual change?
There was a problem hiding this comment.
Yeah I don't know how that other commit got in here. Lemme see if I can clean that up real quick.
There was a problem hiding this comment.
Oh interesting looks like Sentry has a bot that automatically adds a commit to PRs that fixes formatting issues? I'm going to revert that commit and force-push and then merge; don't want to potentially have problems with merge conflicts in the future.
alokedesai
approved these changes
Oct 29, 2024
vorporeal
force-pushed
the
david/fix-logging-macro
branch
from
3f9e323 to
25595d4
Compare
vorporeal
merged commit 56fd585
into
8.36.0-with-subprocess-fix
90 of 100 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time between 8.15 and 8.36, Sentry changed their logging macros, so we need to update our debug log line added in our subprocess patch.