Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LIMIT_BREAKAWAY_OK as available flag #1

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

danielpeng2
Copy link
Member

@danielpeng2 danielpeng2 commented Jan 23, 2025

Description

I had to fork the win32job repo to add this piece of functionality we need.

Adds LIMIT_BREAKAWAY_OK as an available flag on the Job Object. This allows us to spawn child processes that aren't associated with the job, otherwise we get a permission denied error.

Copy link
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously not blocking, but would be nice to see if we maintainers would accept this as a contribution. Would be nice to not have to fork in perpetuity (so we can continue to get new changes to this crate)

@danielpeng2
Copy link
Member Author

danielpeng2 commented Jan 23, 2025

Obviously not blocking, but would be nice to see if we maintainers would accept this as a contribution. Would be nice to not have to fork in perpetuity (so we can continue to get new changes to this crate)

Opened a PR in the original repo, will track and try to get that merged in: ohadravid#8

@danielpeng2 danielpeng2 merged commit 0419cd9 into main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants