Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VirtualKeyboard.java #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PedroGM80
Copy link

In the code I have added capital letters to the keyboard which extends its functionality.

In the code I have added capital letters to the keyboard which extends its functionality.
@PedroGM80
Copy link
Author

I add upercase keys

Copy link
Owner

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PedroGM80. Thanks for your PR and sorry for the late response. I should (and will) pay more attention to my public repos. :-)

Anyway, if I do remember correctly, I decided not to add explicit capitalized letters as keys are already capitalized if shift or caps lock are active. See: https://github.com/PedroGM80/virtualkeyboard/blob/master/src/main/java/wcmjunior/virtualkeyboard/VirtualKeyboard.java#L330

Also, I see that you added VK_DEAD_CEDILLA, likely because you need a keyboard in Spanish. I think the right thing we should do here is to provide an easy way for users to change the keyboard configuration outside of the code itself. Maybe through a JSON file, for example. Then the user that instantiates a new Keyboard class would only provide the key configuration necessary for the target keyboard. This would definitively be much easier then forking the repo. LMK your thoughts. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants