Resubmitting the milestone for Project 2 #40
Conversation
public/javascript/ui.js
Outdated
| @@ -0,0 +1,46 @@ | |||
| (function (window, document) { | |||
There was a problem hiding this comment.
Hmm why are we splitting the javascript file here? any major reasons?
There was a problem hiding this comment.
and why we are using iife method?
views/home.handlebars
Outdated
| <div class="l-content"> | ||
| <div class="pricing-tables pure-g"> | ||
| <div class="pure-u-1 pure-u-md-1-2"> | ||
| <div class="pricing-table pricing-table-biz pricing-table-selected"> |
There was a problem hiding this comment.
why the class name is pricing-table?
| app.set('view engine', 'handlebars') | ||
|
|
||
| // Routes | ||
| app.use('/', routes) |
There was a problem hiding this comment.
Most of your operations happened in sockets, where are the CRUD database operation?
|
Nice to have:
|
| const routes = require('./routes/routes') | ||
| const dbConfig = require('./config/dbConfig') | ||
| const Twit = require('twit') | ||
| const tweet = require('./helpers/twitter') |
There was a problem hiding this comment.
i think you should group all of your helper files under ./helpers/ directory together
| tweet.get('search/tweets', {q: query, count: 50, tweet_mode:'extended', result_type:'reverse'}, function(err, data, res){ | ||
| if(err)(console.log(err)) | ||
| for(let i=0; i<data.statuses.length; i++){ | ||
| if(data.statuses[i].retweeted_status){ |
There was a problem hiding this comment.
can remove this if condition if it's not needed
|
|
||
| tweet.get('search/tweets', {q: query, count: 50, tweet_mode:'extended', result_type:'reverse'}, function(err, data, res){ | ||
| if(err)(console.log(err)) | ||
| for(let i=0; i<data.statuses.length; i++){ |
There was a problem hiding this comment.
try to use forEach instead perhaps?
| // Tracker Page | ||
| router.get('/home', isLoggedIn, HomeController.home) | ||
|
|
||
| router.post('/create', HomeController.create) |
There was a problem hiding this comment.
you should check all post, put, and delete routes too if the current user is authenticated or not too
Deliverable Submission
Please describe your comfort and completeness levels before submitting.
Comfort Level (1-5): 4
Completeness Level (1-5): 3
What did you think of this deliverable?: Working with APIs was more complicated than I thought. Main reason for this was the lack of details in the documentations provided, and required a lot of research + testing.