Ian's Recipe Keeper #134
Open
Ian's Recipe Keeper #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 11, 2020 19:31
| @@ -65,7 +65,7 @@ app.get('/recipe/:id', (req, res) => { | |||
| const index = parseInt(req.params.id); | |||
| const recipe = obj.recipes; | |||
| const data = { | |||
| num: index, | |||
| id: index, | |||
There was a problem hiding this comment.
Should you implement sort functionality for recipes eventually, consider creating an id property for each recipe object. Presently, an 'id' is only assigned to the props object for the purposes of rendering, and also at the routing stage, where the 'id' is correlated to the position of the recipe in its array. This correlation will be broken once any sorting logic is implemented, so a persistent id property may be helpful.
| @@ -18,8 +18,7 @@ class Edit extends React.Component { | |||
| <li class="nav-item"> | |||
| <a class="nav-link active" href="/recipe">Home</a> | |||
| </li> | |||
| </ul> | |||
|
|
|||
| </ul> | |||
| <form method="POST" action={editRecipe}> | |||
| <div class="form-group"> | |||
There was a problem hiding this comment.
Consider using className instead of class in jsx files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliverable Submission
Please describe your comfort and completeness levels before submitting.
Comfort Level (1-5):
3
Completeness Level (1-5):
3
How many hours did you spend on this assignment?
3
What part did you spend the most time on?
Does the assignment run without errors?
If the assignment has errors, what are they?
Describe one part of the code or choose one line you would improve upon.
What would you improve?
What did you think of this deliverable? Any other comments?