-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shane - Recipe Keeper #148
Open
ReadyHash
wants to merge
11
commits into
wdi-sg:master
Choose a base branch
from
ReadyHash:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokchuantan
reviewed
Apr 14, 2020
} | ||
|
||
const correctRecipe = recipeArray.filter(checkID); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some code in to print out the desired content, tried to use filter but can't get it to work
https://floobits.com/kokchuan/SEI22codezz/file/recipe-keeper/views/home.jsx:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliverable Submission
Please describe your comfort and completeness levels before submitting.
Comfort Level : 3
Completeness Level : 2
How many hours did you spend on this assignment?
6 hours
What part did you spend the most time on?
Displaying object based on id
Does the assignment run without errors?
no
If the assignment has errors, what are they?
Describe one part of the code or choose one line you would improve upon.
What would you improve?
The way i structure my objects and variables, so it's easier to read.
What did you think of this deliverable? Any other comments?
I am still slowly understanding the basics, haven't manage to get to the fun stuff like editing and modifying the data.