chore: upgrade Rust to 1.83.0 nightly (#8712)

* chore(deps): Switch anymap to anymap3

anymap seems unmaintained and emits a future incompatibility warning
with newer Rust.

chris-morgan/anymap#53

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore(deps): Upgrade ctor 0.2.3 to 0.2.9

Fixes “warning: unexpected `cfg` condition value: `used_linker`” with
newer Rust.

mmastrac/rust-ctor#309

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore(deps): Replace unmaintained derivative with derive_more

derivative triggers unfixable Clippy lints with new Rust.

rust-lang/rust-clippy#13811

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore: Fix clippy::empty_line_after_doc_comments

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore: Fix clippy::extra_unused_lifetimes

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore: Fix clippy::manual_c_str_literals

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore: Fix clippy::needless_lifetimes

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore: Fix clippy::needless_return

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore: Fix clippy::unnecessary_map_or

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

* chore: upgrade Rust to 1.83.0 nightly

Upgrade Rust to nightly-2024-11-27, which was built on the same day as
1.83.0 stable.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

---------

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Cargo.toml

@@ -29,7 +29,7 @@ ignored = [
 ]
 [workspace.dependencies]
 anyhow             = { version = "1.0.94", features = ["backtrace"] }
-anymap             = { version = "=1.0.0-beta.2" }
+anymap             = { package = "anymap3", version = "1.0.1" }
 async-recursion    = { version = "1.1.1" }
 async-scoped       = { version = "0.9.0" }
 async-trait        = { version = "0.1.83" }
@@ -39,7 +39,7 @@ concat-string      = { version = "1.0.1" }
 cow-utils          = { version = "0.1.3" }
 css-module-lexer   = { version = "0.0.15" }
 dashmap            = { version = "6.1.0" }
-derivative         = { version = "2.2.0" }
+derive_more        = { version = "1.0.0" }
 either             = { version = "1.13.0" }
 futures            = { version = "0.3.31" }
 glob               = { version = "0.3.1" }

crates/rspack_binding_options/Cargo.toml

@@ -15,7 +15,7 @@ ignored = ["tracing"]
 [dependencies]
 async-trait                            = { workspace = true }
 cow-utils                              = { workspace = true }
-derivative                             = { workspace = true }
+derive_more                            = { workspace = true, features = ["debug"] }
 glob                                   = { workspace = true }
 napi                                   = { workspace = true, features = ["async", "tokio_rt", "serde-json", "anyhow"] }
 napi-derive                            = { workspace = true }

crates/rspack_binding_options/src/options/raw_builtins/raw_banner.rs

@@ -1,4 +1,4 @@
-use derivative::Derivative;
+use derive_more::Debug;
 use napi::Either;
 use napi_derive::napi;
 use rspack_binding_values::{into_asset_conditions, JsChunkWrapper, RawAssetConditions};
@@ -15,7 +15,7 @@ pub struct JsBannerContentFnCtx {
   pub filename: String,
 }
 
-impl<'a> From<BannerContentFnCtx<'a>> for JsBannerContentFnCtx {
+impl From<BannerContentFnCtx<'_>> for JsBannerContentFnCtx {
   fn from(value: BannerContentFnCtx) -> Self {
     Self {
       hash: value.hash.to_string(),
@@ -44,11 +44,10 @@ impl TryFrom<RawBannerContentWrapper> for BannerContent {
   }
 }
 
-#[derive(Derivative)]
-#[derivative(Debug)]
+#[derive(Debug)]
 #[napi(object, object_to_js = false)]
 pub struct RawBannerPluginOptions {
-  #[derivative(Debug = "ignore")]
+  #[debug(skip)]
   #[napi(ts_type = "string | ((...args: any[]) => any)")]
   pub banner: RawBannerContent,
   pub entry_only: Option<bool>,

crates/rspack_binding_options/src/options/raw_builtins/raw_copy.rs

@@ -1,5 +1,5 @@
 use cow_utils::CowUtils;
-use derivative::Derivative;
+use derive_more::Debug;
 use napi::{bindgen_prelude::Buffer, Either};
 use napi_derive::napi;
 use rspack_core::rspack_sources::RawSource;
@@ -22,12 +22,11 @@ pub struct RawToOptions {
   pub absolute_filename: String,
 }
 
-#[derive(Derivative)]
-#[derivative(Debug, Clone)]
+#[derive(Debug, Clone)]
 #[napi(object, object_to_js = false)]
 pub struct RawCopyPattern {
   pub from: String,
-  #[derivative(Debug = "ignore")]
+  #[debug(skip)]
   #[napi(
     ts_type = "string | ((pathData: { context: string; absoluteFilename?: string }) => string | Promise<string>)"
   )]
@@ -39,7 +38,7 @@ pub struct RawCopyPattern {
   pub priority: i32,
   pub glob_options: RawCopyGlobOptions,
   pub info: Option<RawInfo>,
-  #[derivative(Debug = "ignore")]
+  #[debug(skip)]
   #[napi(
     ts_type = "(input: Buffer, absoluteFilename: string) => string | Buffer | Promise<string> | Promise<Buffer>"
   )]

crates/rspack_binding_options/src/options/raw_builtins/raw_progress.rs

@@ -1,14 +1,13 @@
 use std::sync::Arc;
 
-use derivative::Derivative;
+use derive_more::Debug;
 use napi::Either;
 use napi_derive::napi;
 use rspack_napi::threadsafe_function::ThreadsafeFunction;
 use rspack_plugin_progress::{ProgressPluginDisplayOptions, ProgressPluginOptions};
 
 type HandlerFn = ThreadsafeFunction<(f64, String, Vec<String>), ()>;
-#[derive(Derivative)]
-#[derivative(Debug)]
+#[derive(Debug)]
 #[napi(object, object_to_js = false)]
 pub struct RawProgressPluginOptions {
   // the prefix name of progress bar
@@ -22,7 +21,7 @@ pub struct RawProgressPluginOptions {
   // the progress characters
   pub progress_chars: Option<String>,
   // the handler for progress event
-  #[derivative(Debug = "ignore")]
+  #[debug(skip)]
   #[napi(ts_type = "(percent: number, msg: string, items: string[]) => void")]
   pub handler: Option<HandlerFn>,
 }

crates/rspack_binding_options/src/options/raw_builtins/raw_size_limits.rs

@@ -1,13 +1,12 @@
-use derivative::Derivative;
+use derive_more::Debug;
 use napi_derive::napi;
 use rspack_napi::threadsafe_function::ThreadsafeFunction;
 use rspack_plugin_size_limits::{AssetFilterFn, SizeLimitsPluginOptions};
 
-#[derive(Derivative)]
-#[derivative(Debug)]
+#[derive(Debug)]
 #[napi(object, object_to_js = false)]
 pub struct RawSizeLimitsPluginOptions {
-  #[derivative(Debug = "ignore")]
+  #[debug(skip)]
   #[napi(ts_type = "(assetFilename: string) => boolean")]
   pub asset_filter: Option<ThreadsafeFunction<String, bool>>,
   #[napi(ts_type = "\"error\" | \"warning\"")]

crates/rspack_binding_options/src/options/raw_module/mod.rs

@@ -1,7 +1,7 @@
 use std::fmt::Formatter;
-use std::{collections::HashMap, fmt::Debug, sync::Arc};
+use std::{collections::HashMap, sync::Arc};
 
-use derivative::Derivative;
+use derive_more::Debug;
 use napi::bindgen_prelude::Either3;
 use napi::Either;
 use napi_derive::napi;
@@ -491,15 +491,14 @@ impl From<RawGeneratorOptions> for GeneratorOptions {
   }
 }
 
-#[derive(Derivative, Default)]
-#[derivative(Debug)]
+#[derive(Default, Debug)]
 #[napi(object, object_to_js = false)]
 pub struct RawAssetGeneratorOptions {
   pub emit: Option<bool>,
   pub filename: Option<JsFilename>,
   #[napi(ts_type = "\"auto\" | JsFilename")]
   pub public_path: Option<JsFilename>,
-  #[derivative(Debug = "ignore")]
+  #[debug(skip)]
   #[napi(
     ts_type = "RawAssetGeneratorDataUrlOptions | ((arg: RawAssetGeneratorDataUrlFnArgs) => string)"
   )]
@@ -519,11 +518,10 @@ impl From<RawAssetGeneratorOptions> for AssetGeneratorOptions {
   }
 }
 
-#[derive(Derivative, Default)]
-#[derivative(Debug)]
+#[derive(Default, Debug)]
 #[napi(object, object_to_js = false)]
 pub struct RawAssetInlineGeneratorOptions {
-  #[derivative(Debug = "ignore")]
+  #[debug(skip)]
   #[napi(
     ts_type = "RawAssetGeneratorDataUrlOptions | ((arg: RawAssetGeneratorDataUrlFnArgs) => string)"
   )]