Add CSS interactivity feature
#2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
flackr
force-pushed
the
interactivity
branch
from
81870d0 to
c45aa17
Compare
flackr
force-pushed
the
interactivity
branch
from
c45aa17 to
2f10b2d
Compare
captainbrosset
approved these changes
Feb 20, 2025
features/interactivity.yml
Outdated
| @@ -0,0 +1,3 @@ | |||
| name: interactivity | |||
| description: The CSS `interactivity` property specifies whether an element and its descendants are inert or not. | |||
There was a problem hiding this comment.
Suggested change
| description: The CSS `interactivity` property specifies whether an element and its descendants are inert or not. | |
| description: The CSS `interactivity` property makes an element and its descendants inert, like when using the `inert` HTML attribute. Inert elements can't be focused or clicked, their text can't be selected or found using the browser's find-in-page feature. |
I thought it'd be good to give more details about what inert means, and to mention the related html attribute as well.
There was a problem hiding this comment.
I added the more detailed suggestion @jamesnw suggested.
jamesnw
reviewed
Feb 20, 2025
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
ddbeck
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Two small suggestions in line comments. This also needs a dist file (via npm run dist) to get merged.
This looks near enough to having an implementation tracked in BCD (if https://chromestatus.com/feature/5107436833472512 is to be believed) that we don't really have to wait on this, once it's merge-able.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.