Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several discouraged JavaScript features #2670

Merged
merged 13 commits into from
Mar 1, 2025

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Feb 18, 2025

This PR adds several discouraged JavaScript features, building on @captainbrosset's work in #2564. The features are:

  • Accessor methods (__defineGetter__() and __defineSetter__())
  • Date.prototype.{get,set}Year()
  • Date.prototype.toGMTString()
  • escape() and unescape() global methods
  • HTML wrapper methods (e.g., String.prototype.blink())
  • Object.prototype.__proto__
  • RegExp.prototype.compile()

Supersedes and closes #2564.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Feb 18, 2025
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

@captainbrosset captainbrosset merged commit 90f3498 into web-platform-dx:main Mar 1, 2025
3 checks passed
@ddbeck ddbeck deleted the discouraged-javascript branch March 2, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants