Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest.launch_handler into web-platform-dx features #2701

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Dp-Goog
Copy link

@Dp-Goog Dp-Goog commented Feb 25, 2025

This CL adds a web-platform-dx entry for launch_handler in manifest.

Spec: https://wicg.github.io/web-app-launch/

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Feb 25, 2025
@Dp-Goog
Copy link
Author

Dp-Goog commented Feb 25, 2025

@captainbrosset

Hi! Please take a look at this CL, this is my first one and I need approval from a maintainer to start the workflow. I'm a Software Engineer from Chrome looking to add some features here around the PWA area.

I based this off feedback from #2395.

@Dp-Goog
Copy link
Author

Dp-Goog commented Feb 26, 2025

@ddbeck and @captainbrosset seems like I do not have the necessary privileges for assigning someone to review my CL or trigger the workflow. Can I get your help again please? Thanks!

@ddbeck ddbeck self-requested a review February 26, 2025 21:59
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR, @Dp-Goog. Some suggestions for you inline.

@@ -0,0 +1,9 @@
name: Launch Handler
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we pluralize other "handlers" for web app manifests. @captainbrosset maybe you have an opinion about this?

Also, a nit: we use title case for feature names

Suggested change
name: Launch Handler
name: Launch handlers

(If this change is accepted, then the ID for the feature should change to match.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait on @captainbrosset 's feedback here.

@Dp-Goog Dp-Goog requested a review from ddbeck February 28, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants