-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifest.launch_handler into web-platform-dx features #2701
base: main
Are you sure you want to change the base?
Conversation
Hi! Please take a look at this CL, this is my first one and I need approval from a maintainer to start the workflow. I'm a Software Engineer from Chrome looking to add some features here around the PWA area. I based this off feedback from #2395. |
@ddbeck and @captainbrosset seems like I do not have the necessary privileges for assigning someone to review my CL or trigger the workflow. Can I get your help again please? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR, @Dp-Goog. Some suggestions for you inline.
features/app-launch-handler.yml
Outdated
@@ -0,0 +1,9 @@ | |||
name: Launch Handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we pluralize other "handlers" for web app manifests. @captainbrosset maybe you have an opinion about this?
Also, a nit: we use title case for feature names
name: Launch Handler | |
name: Launch handlers |
(If this change is accepted, then the ID for the feature should change to match.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will wait on @captainbrosset 's feedback here.
This CL adds a web-platform-dx entry for launch_handler in manifest.
Spec: https://wicg.github.io/web-app-launch/