Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unifies the interface specification #20

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mutezebra
Copy link
Member

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

这个 PR 做了什么 / 我们为什么需要这个 PR?

  1. 把 gateway 文件夹从根目录下移动到了 app 下
  2. 统一了接口命名规范,用 v1 来注明版本
  3. 将需要暴露出 http 接口的部分放在 idl/api 下,使用不同的文件和 namespace 区分不同服务
  4. 更新了 makefile 相关 hz 的命令
  5. 补充了 order 和 cart 部分的 http 部分

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

Copy link
Member

@SchwarzSail SchwarzSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mutezebra mutezebra merged commit 8879c2f into west2-online:main Feb 12, 2025
8 checks passed
@mutezebra mutezebra deleted the gateway branch February 12, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants