Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add interactive git attributes generator #408

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

sandr01d
Copy link
Collaborator

@sandr01d sandr01d commented Nov 12, 2024

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

Adds an interactive .gitattributes generator that works exactly the same as the one we already have for .gitignore. I've refactored the functions used in _forgit_ignore(), so they can also be used for _forgit_attributes(). When testing, it's a good idea to also test that gi still works as it did before.
Marked this as a draft, because I first want to sort out what to do with #407 and refactor _forgit_ignore_clean if necessary.

Closes #405

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

@sandr01d sandr01d mentioned this pull request Feb 7, 2025
10 tasks
@sandr01d sandr01d marked this pull request as ready for review February 10, 2025 18:42
Copy link
Collaborator

@carlfriedrich carlfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks a lot @sandr01d!

Copy link
Collaborator

@cjappl cjappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for humoring me, made it a lot easier to review.

LGTM

@sandr01d sandr01d merged commit 0d65efc into main Feb 14, 2025
7 checks passed
@sandr01d sandr01d deleted the gitattributes branch February 14, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: .gitattributes generator
3 participants