Meta: do not create tag when there are no public changes #414
Conversation
|
Do we want to check all the commit messages between the last tag and head for the If that's the case I have the fix stashed and I can update this PR with that approach. |
|
Hey @suft, thanks for helping out with this!
Yes, I think that is the behavior we'd want. Ideally we'd match the Meta prefix case insensitive. |
suft
force-pushed
the
meta-no-tags
branch
2 times, most recently
from
3032809 to
67a1aad
Compare
|
Thanks @suft for your take on this. While this is definitely a quick fix for the problem, I do not find it optimal because it duplicates the logic we already have in |
|
@suft Thanks again for your update. The new version won't work, unfortunately, because the output of the tag creation goes to Furthermore, the name of the script Now that I think more about it, though, I think the two scripts might still be separate, but we should only reduce the two workflows into one. The My offer is still valid, I can implement this myself during the next days. If you @suft are motivated, though, feel free to continue on this. Your effort is very much appreciated! 🙏 |
|
Another thing just came to my mind: there was a reason we had the tag and release actions separate, and that is we want to have the possibility to trigger custom releases by creating a tag manually. So the new combined workflow should also support this (i.e. triggered on tag creation and create tag only if it does not exist, yet). |
This is mostly a refactoring of our GitHub actions. The tag workflow and script have been removed completely, since the release action will implicitly create the release tag if it does not exit, yet. This makes sure that we do not create a tag when there will be no release. We have only one workflow now, which contains two jobs: one for generating the changelog and one for creating the release. The changelog job will generate the changelog and upload it as an artifact if there are public changes. The release version, which previously was determined in the tag script, is now determined within this job, so that we can pass it to the release job. The release job will run only if the changelog job was successful, i.e. if there are public changes. It will create a tag and a GitHub release with the given version number. The workflow will run on the first day of every month for our regular automatic monthly releases. It will also run on every tag push, so that we still can create a release manually if necessary. The release action will implicitly use the existing tag for the release then. Fixes wfxr#413 Closes wfxr#414
Check list
Description
forgit-24.12.0.tar.gzfor 24.12.0 tag #413Type of change
Test environment